| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, amul sul <sulamul(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Peter Geoghegan <pg(at)bowt(dot)ie>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: wal_consistency_checking reports an inconsistency on master branch |
| Date: | 2018-04-13 10:12:58 |
| Message-ID: | 0c11a775-3ff8-27fa-a7d4-d4e89761db97@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018/04/13 19:08, Michael Paquier wrote:
> On Fri, Apr 13, 2018 at 02:15:35PM +0530, amul sul wrote:
>> I have looked into this and found that the issue is in heap_xlog_delete -- we
>> have missed to set the correct offset number from the target_tid when
>> XLH_DELETE_IS_PARTITION_MOVE flag is set.
>
> Oh, this looks good to me. So when a row was moved across partitions
> this could have caused incorrect tuple references on a standby, which
> could have caused corruptions.
>
> wal_consistency_checking is proving to be worth its cost here...
+1
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2018-04-13 10:13:36 | Re: crash with sql language partition support function |
| Previous Message | Michael Paquier | 2018-04-13 10:08:40 | Re: wal_consistency_checking reports an inconsistency on master branch |