Change error to warning and increase thresholds of tsearch

From: Ankit Kumar Pandey <itsankitkp(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Change error to warning and increase thresholds of tsearch
Date: 2022-11-14 20:16:00
Message-ID: 0c06a4d5-0ffd-a660-2e0b-e06d66a22cea@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I was looking at Todo item:/Consider changing error to warning for strings larger than one megabyte/
and after going through existing mails and suggestions. I would like to propose a patch for tsearch to change error into warning for string larger than one mb and also increase word and position limits.

I've checked operations select/insertion/index, which worked fine without any error (except for the warning as intended).

Thoughts: I am not really sure why was it proposed in the mail to decrease len/MAXSTRLEN.
> You could decrease len in WordEntry to 9 (512 characters) and increase
> pos to 22 (4 Mb). Don't forget to update MAXSTRLEN and MAXSTRPOS
> accordingly.

I'm attaching a patch herewith. I will be glad to get some feedback on this.

Thanks,
Ankit

Attachment Content-Type Size
v1-0001-change-error-to-warn-for-tsearch-and-increase-limits.patch text/x-patch 1.8 KB

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2022-11-14 20:42:26 Re: Suppressing useless wakeups in walreceiver
Previous Message David Christensen 2022-11-14 19:59:04 Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL