Re: [PATCH] SortSupport for macaddr type

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Brandur Leach <brandur(at)mutelight(dot)org>
Cc: Neha Khatri <nehakhatri5(at)gmail(dot)com>, Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] SortSupport for macaddr type
Date: 2017-03-14 10:25:38
Message-ID: 0be5a36c-6492-538e-5057-b8a37e948f95@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Looks straightforward at a quick read-through. I have just a couple of
questions. How much of the performance gain comes from avoiding the
FunctionCallInvoke overhead, by simply having SortSupport with a
comparison function, and how much comes from the "abbreviation"?

Also, is it worth the cycles and code to have the hyperloglog estimator,
and aborting the abbreviation if there are only a few distinct values.
Or put another way, how much does the abbreviation slow things down in
the worst case?

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2017-03-14 10:59:57 Re: multivariate statistics (v25)
Previous Message Heikki Linnakangas 2017-03-14 10:15:51 Re: scram and \password