| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Alexander Lakhin <exclusion(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: WaitEventSet resource leakage |
| Date: | 2023-11-23 11:35:16 |
| Message-ID: | 0b1770f1-b211-46aa-94cd-ee15c9cb934b@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 22/11/2023 15:00, Alexander Lakhin wrote:
> I can also confirm that the patches proposed (for master and back branches)
> eliminate WES leakage as expected.
>
> Thanks for the fix!
>
> Maybe you would find appropriate to add the comment
> /* Convenience wrappers over ResourceOwnerRemember/Forget */
> above ResourceOwnerRememberWaitEventSet
> just as it's added above ResourceOwnerRememberRelationRef,
> ResourceOwnerRememberDSM, ResourceOwnerRememberFile, ...
Added that and fixed the Windows warning that Thomas pointed out. Pushed
the ResourceOwner version to master, and PG_TRY-CATCH version to 14-16.
Thank you!
> (As a side note, this fix doesn't resolve the issue #17828 completely,
> because that large number of handles might be also consumed
> legally.)
:-(
--
Heikki Linnakangas
Neon (https://neon.tech)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bono Stebler | 2023-11-23 11:55:58 | Use index to estimate expression selectivity |
| Previous Message | Dean Rasheed | 2023-11-23 11:07:33 | Re: [PATCH] psql: Add tab-complete for optional view parameters |