| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Michael Banck <michael(dot)banck(at)credativ(dot)de> |
| Subject: | Re: Online checksums patch - once again |
| Date: | 2021-01-26 22:37:22 |
| Message-ID: | 0a79fe43-ec1e-ad7f-9bfe-4f2f0a69b480@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 22/01/2021 14:21, Heikki Linnakangas wrote:
> On 22/01/2021 13:55, Heikki Linnakangas wrote:
>> I read through the latest patch,
>> v31-0001-Support-checksum-enable-disable-in-a-running-clu.patch. Some
>> comments below:
>
> One more thing:
>
> In SetRelationNumChecks(), you should use SearchSysCacheCopy1() to get a
> modifiable copy of the tuple. Otherwise you modify the tuple in the
> relcache as a side effect. Maybe that's harmless in this case, as the
> 'relhaschecksums' value in the relcache isn't used for anything, but
> let's be tidy.
Sorry, I meant SetRelHasChecksums. There is no SetRelationNumChecks
function, I don't know where I got that from.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2021-01-26 22:53:01 | Re: Key management with tests |
| Previous Message | Alexey Kondratov | 2021-01-26 22:00:50 | Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly |