| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Langote <amitlangote09(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: BEFORE trigger can cause undetected partition constraint violation |
| Date: | 2017-06-08 00:04:24 |
| Message-ID: | 0a6a028e-ae6d-0d3a-97b7-7782306f4f04@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017/06/08 2:07, Robert Haas wrote:
> On Wed, Jun 7, 2017 at 1:23 AM, Amit Langote
> <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> On 2017/06/07 11:57, Amit Langote wrote:
>>> How about we export ExecPartitionCheck() out of execMain.c and call it
>>> just before ExecFindPartition() using the root table's ResultRelInfo?
>>
>> Turns out there wasn't a need to export ExecPartitionCheck after all.
>> Instead of calling it from execModifyTable.c and copy.c, it's better to
>> call it at the beginning of ExecFindPartition() itself. That way, there
>> is no need to add the same code both in CopyFrom() and ExecInsert(), nor
>> is there need to make ExecPartitionCheck() public. That's how the patch
>> attached with the previous email does it anyway.
>
> Cool. I think this is a sensible approach, and have committed the patch.
Thanks a lot.
Regards,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-06-08 00:07:40 | Re: [PATCH] Fixed malformed error message on malformed SCRAM message. |
| Previous Message | Thomas Munro | 2017-06-07 23:50:40 | Re: PG10 transition tables, wCTEs and multiple operations on the same table |