Re: Slot's restart_lsn may point to removed WAL segment after hard restart unexpectedly

From: Alexander Lakhin <exclusion(at)gmail(dot)com>
To: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Cc: Vitaly Davydov <v(dot)davydov(at)postgrespro(dot)ru>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, tomas(at)vondra(dot)me
Subject: Re: Slot's restart_lsn may point to removed WAL segment after hard restart unexpectedly
Date: 2025-06-15 15:00:01
Message-ID: 0a617d34-abc3-4090-92a5-ea15d45e36f6@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

15.06.2025 14:02, Alexander Korotkov wrote:
> Could you, please, check this patch? On my system it makes 046 and
> 047 execute in 140 secs with -O0 and -DRELCACHE_FORCE_RELEASE
> -DCATCACHE_FORCE_RELEASE.

Thank you for the patch!

It decreases the test's duration significantly:
# +++ tap check in src/test/recovery +++
t/046_checkpoint_logical_slot.pl .. ok
All tests successful.
Files=1, Tests=1, 29 wallclock secs ( 0.01 usr  0.00 sys +  0.23 cusr  0.56 csys =  0.80 CPU)

Without the patch:
t/046_checkpoint_logical_slot.pl .. ok
All tests successful.
Files=1, Tests=1, 519 wallclock secs ( 0.01 usr  0.00 sys +  3.05 cusr  7.64 csys = 10.70 CPU)
Result: PASS

Best regards,
Alexander

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jinliang Zheng 2025-06-15 15:13:58 Question about RWF_DONTCACHE
Previous Message Andrey Borodin 2025-06-15 13:24:04 Re: Amcheck verification of GiST and GIN