| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Silence a new Valgrind warning |
| Date: | 2026-03-13 15:33:09 |
| Message-ID: | 0a25470a-6188-4180-bc5e-53cbb3b1f2ab@iki.fi |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/03/2026 14:56, Aleksander Alekseev wrote:
> Commit 4966bd3ed95e revealed a non-critical memory leak in
> ProcessStartupPacket() which Valgrind is very much upset about:
>
> ```
> 63 (32 direct, 31 indirect) bytes in 1 blocks are definitely lost in
> loss record 355 of 800
> at 0x9D260C: palloc (mcxt.c:1411)
> by 0x54B3D2: new_list (list.c:137)
> by 0x54B8CC: lappend (list.c:344)
> by 0x78B41A: ProcessStartupPacket (backend_startup.c:786)
> by 0x78A411: BackendInitialize (backend_startup.c:295)
> by 0x789F2F: BackendMain (backend_startup.c:110)
> by 0x67EEED: postmaster_child_launch (launch_backend.c:268)
> by 0x685D50: BackendStartup (postmaster.c:3606)
> by 0x6830CF: ServerLoop (postmaster.c:1713)
> by 0x682982: PostmasterMain (postmaster.c:1403)
> by 0x547DFE: main (main.c:231)
> ```
>
> The proposed patch silences the warnings.
I don't see that warning. What valgrind options did you use?
The patch looks good to me.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2026-03-13 15:36:31 | Re: Import Statistics in postgres_fdw before resorting to sampling. |
| Previous Message | Greg Burd | 2026-03-13 15:29:35 | Re: Speed up COPY FROM text/CSV parsing using SIMD |