| From: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, Andres Freund <andres(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp> |
| Subject: | Re: narwhal and PGDLLIMPORT |
| Date: | 2014-02-20 08:31:39 |
| Message-ID: | 0MFKbs-1WSRj91hZM-00ELuH@mrelayeu.kundenserver.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
(Top post, on phone)
The @number part is optional. It indicates an export ordinal. (You don't want to know, if you do, see MSDN).
If you remove them or change them then binaries linked to the older version will fail to link to the newer; it breaks binary compat. The ordinals are part of the library ABI.
On 20 Feb 2014 07:28, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>
> Tom Lane escribió:
> > Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp> writes:
> > > Attached is a patch to remove dllwarp from pgevent/Makefile.
> >
> > Actually, it looks like this patch doesn't work at all:
> >
> > http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacana&dt=2014-02-20%2001%3A00%3A53
> >
> > Did I fat-finger the commit somehow? I made a couple of cosmetic
> > changes, or at least I thought they were cosmetic.
>
> The format of the file is completely unlike that of the other *dll.def
> files we use elsewhere. AFAICT each line is
>
> <tab>symbolname@<tab>some_number
>
> --
> Álvaro Herrera http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | amul sul | 2014-02-20 08:43:00 | Re: Selecting large tables gets killed |
| Previous Message | Pavel Stehule | 2014-02-20 08:17:42 | Re: Fwd: patch: make_timestamp function |