| From: | "Imai, Yoshikazu" <imai(dot)yoshikazu(at)jp(dot)fujitsu(dot)com> |
|---|---|
| To: | "Imai, Yoshikazu" <imai(dot)yoshikazu(at)jp(dot)fujitsu(dot)com>, 'Amit Langote' <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | 'Amit Langote' <amitlangote09(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
| Subject: | RE: speeding up planning with partitions |
| Date: | 2019-03-15 05:40:26 |
| Message-ID: | 0F97FA9ABBDBE54F91744A9B37151A5129E7D2@g01jpexmbkw24 |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Amit-san,
I have another little comments about v31-patches.
* We don't need is_first_child in inheritance_planner().
On Fri, Mar 8, 2019 at 9:18 AM, Amit Langote wrote:
> On 2019/03/08 16:16, Imai, Yoshikazu wrote:
> > I attached the diff of modification for v26-0003 patch which also
> contains some refactoring.
> > Please see if it is ok.
>
> I like the is_first_child variable which somewhat improves readability,
> so updated the patch to use it.
I noticed that detecting first child query in inheritance_planner() is already done by "final_rtable == NIL"
/*
* If this is the first non-excluded child, its post-planning rtable
* becomes the initial contents of final_rtable; otherwise, append
* just its modified subquery RTEs to final_rtable.
*/
if (final_rtable == NIL)
So I think we can use that instead of using is_first_child.
--
Yoshikazu Imai
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Edmund Horner | 2019-03-15 05:42:40 | Re: Tid scan improvements |
| Previous Message | Matsumura, Ryo | 2019-03-15 05:27:01 | RE: Is PREPARE of ecpglib thread safe? |