Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tobias Bussmann <t(dot)bussmann(at)gmx(dot)net>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Mark Guertin <markguertin(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files
Date: 2023-05-02 10:34:59
Message-ID: 0F3A9C7C-CEDA-45CC-9A75-9E2A17269324@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

> On 1 May 2023, at 23:23, Tobias Bussmann <t(dot)bussmann(at)gmx(dot)net> wrote:

> The safe solution for the back branches would be to add '{".DS_Store", false}' to the exclude_list_item arrays in backend/backup/basebackup.c, bin/pg_checksums/pg_checksums.c and bin/pg_rewind/filemap.c, but I can't judge whether this would justify using a different codepath for the older versions or not.

If we deem this to be a bugfix then we should backpatch the solution from HEAD
imho. So far there are mainly voices for considering it a bugfix, but given
where we are in the cycle I the RMT has the final say on that.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Daniel Gustafsson 2023-05-02 11:01:00 Re: plpython does not honour max-rows
Previous Message Kieran McCusker 2023-05-02 10:30:16 plpython does not honour max-rows