Re: Few untranslated error messages in OAuth

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Few untranslated error messages in OAuth
Date: 2025-11-13 12:49:27
Message-ID: 0EEBCAA8-A5AC-4E3B-BABA-0BA7A08C361B@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 13 Nov 2025, at 13:32, Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> On 2025-Nov-13, Daniel Gustafsson wrote:
>
>> I was pondering that since auth error messages in backend libpq does this, but
>> since we don't use gettext_noop anywhere else in frontend libpq today it makes
>> sense to go with libpq_gettext and update the docs instead.
>>
>> Unless you, who has more translation/nls insights than me, feel strongly about
>> gettext_noop I'll go ahead with the current patch.
>
> gettext_noop() does something completely different from libpq_gettext(),
> and the more I think about this, the more I think doing libpq_gettext()
> is the wrong thing.

If so, should that be extended to oauth_json_set_error as well? (and possibly others?)

> I can give it a shot if you want.

If you have time, that would be great.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Álvaro Herrera 2025-11-13 12:55:01 Re: Consistently use the XLogRecPtrIsInvalid() macro
Previous Message Álvaro Herrera 2025-11-13 12:32:27 Re: Few untranslated error messages in OAuth