Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tobias Bussmann <t(dot)bussmann(at)gmx(dot)net>, Mark Guertin <markguertin(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files
Date: 2023-04-20 07:34:12
Message-ID: 0EE6FAF4-526D-4096-BDE2-FAE7FA6AFBA1@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

> On 20 Apr 2023, at 02:15, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Apr 19, 2023 at 02:15:51PM -0400, Tom Lane wrote:
>> Yeah. I wonder if we ought to do something more general, and
>> ignore all files whose names start with ".".
>
> Indeed. I don't see any point is adding hidden files for the
> checksum, rewind and base backup lists, so we could just make it a
> hardcoded rule. That's currently what we do for configuration files
> when using include_dir for postgresql.conf (as well as hba and ident
> files in 16~).

+1, it will keep editor leftovers away as well.

--
Daniel Gustafsson

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Junwang Zhao 2023-04-20 07:40:14 Re: BUG #17903: There is a bug in the KeepLogSeg()
Previous Message Andrey Lepikhov 2023-04-20 05:06:51 Re: Clause accidentally pushed down ( Possible bug in Making Vars outer-join aware)