From: | Ted Kremenek <kremenek(at)cs(dot)stanford(dot)edu> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-bugs(at)postgresql(dot)org, Michael Meskes <meskes(at)postgresql(dot)org>, Neil Conway <neilc(at)samurai(dot)com> |
Subject: | Re: [CHECKER] 4 memory leaks in Postgresql 7.4.2 |
Date: | 2004-05-03 03:22:07 |
Message-ID: | 0E9EB102-9CB1-11D8-BF2F-000393B3CE92@cs.stanford.edu |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
Since the tool is in its nascent stages, I reported only a handful of
reports that I myself looked at felt that they were potentially bugs.
I appreciate everyone's feedback.
Best,
Ted
On May 2, 2004, at 4:50 PM, Tom Lane wrote:
> Neil Conway <neilc(at)samurai(dot)com> writes:
>> The problem with applying this kind of static analysis to PostgreSQL
>> is
>> that palloc() is not like malloc(): if the return value goes out of
>> scope before it is freed, it is NOT necessarily the case that a memory
>> leak has occurred.
>
> I'm a bit surprised that a tool unaware of this fact would generate
> only
> four complaints ... I'd have expected hundreds.
>
> I concur with Neil's opinion that none of the backend cases represent
> bugs. However:
>
>>> [BUG] memory leak on error path (dtype != DTK_DELTA)
>>> File where bug occurred:
>>> postgresql-7.4.2/src/interfaces/ecpg/pgtypeslib/interval.c
>
>> Looks suspicious to me, but ECPG is Michael Meskes' domain -- Michael?
>
> It's entirely likely that ecpg's derivative of the backend's datetime
> modules contains lots and lots of memory leaks, since AFAIK the palloc
> infrastructure is not there in the ecpg environment :-(.
>
> regards, tom lane
>
> ---------------------------(end of
> broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faqs/FAQ.html
From | Date | Subject | |
---|---|---|---|
Next Message | Timo Nentwig | 2004-05-03 16:08:23 | Bug in optimizer |
Previous Message | Tom Lane | 2004-05-02 23:50:46 | Re: [CHECKER] 4 memory leaks in Postgresql 7.4.2 |
From | Date | Subject | |
---|---|---|---|
Next Message | Philip Warner | 2004-05-03 03:35:18 | Re: ANALYZE locks pg_listener in EXCLUSIVE for long |
Previous Message | Bruce Momjian | 2004-05-03 03:13:04 | Re: ANALYZE locks pg_listener in EXCLUSIVE for long time? |