| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Remaining dependency on setlocale() |
| Date: | 2025-12-13 09:48:13 |
| Message-ID: | 0E8DD47F-710D-45E1-B87F-2336042A377E@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Dec 13, 2025, at 04:11, Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
>
> I believe v12 0001-0005 are about ready for commit, and 0003 should be
> backported.
I quickly went through 0001-0005, and got a few nitpicks:
1 - 0001
```
+ int match_mblen pg_attribute_unused();
```
Why this variable is marked unused? It’s actually used.
2 - 0002
I did a search and found one place that you missed at line 181 in pg_locale.h
```
extern bool char_is_cased(char ch, pg_locale_t locale);
```
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jelte Fennema-Nio | 2025-12-13 10:33:51 | Re: Support named (destination) portals in extended proto for psql meta commands. |
| Previous Message | Masahiko Sawada | 2025-12-13 08:57:14 | Re: POC: enable logical decoding when wal_level = 'replica' without a server restart |