Backend specific ifdefs in sha2.h

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Backend specific ifdefs in sha2.h
Date: 2019-06-13 07:32:28
Message-ID: 0DF29010-CE26-4F51-85A6-9C8ABF5536F9@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The #ifdef guards in sha2.h are using USE_SSL when they in fact are guarding
the inclusion of OpenSSL specific code. This has never caused any issues as
there only is a single supported TLS backend in core so far, but since we’ve
spent a significant amount of energy on making the TLS backend non-hardcoded
it seems we should fix this too. The Makefile around sha2.c/sha2_openssl.c is
already testing for openssl rather than ssl (which given src/Makefile.global
variables makes perfect sense of course).

cheers ./daniel

Attachment Content-Type Size
sha2_ifdefs.patch application/octet-stream 1.5 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-06-13 07:57:19 Re: [PATCH] vacuumlo: print the number of large objects going to be removed
Previous Message Masahiko Sawada 2019-06-13 07:26:47 Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)