Re: LLVM breakage on seawasp

Hi,

On August 24, 2019 1:08:11 PM PDT, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>Hi,
>
>llvmjit_inline.cpp:177:55: error: ‘make_unique’ is not a member of
>‘llvm’
> std::unique_ptr<ImportMapTy> globalsToInline =
>llvm::make_unique<ImportMapTy>();
>
>That's because they just moved to C++14 and replaced their own
>llvm::make_unique<> with std::make_unique<>:
>
>https://github.com/llvm-mirror/llvm/commit/114087caa6f95b526861c3af94b3093d9444c57b
>
>Perhaps we'll need some macrology to select between llvm and std
>versions? I am guessing we can't decree that PostgreSQL's minimum C++
>level is C++14 and simply change it to std::make_unique.

Perhaps just a
#if new_enough
using std::make_unique
#else
using llvm::mak_eunique

At the start of the file, and then use it unqualified?

Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.