| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Maxim Orlov <orlovmg(at)gmail(dot)com>, Daniil Davydov <3danissimo(at)gmail(dot)com> |
| Subject: | Re: Move SLRU_PAGES_PER_SEGMENT to pg_config_manual.h |
| Date: | 2025-11-10 11:41:01 |
| Message-ID: | 0D7A4044-3E31-4AB0-8DA7-54A805B2913C@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 10 Nov 2025, at 12:29, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> There was a suggestion earlier to make SLRU_PAGES_PER_SEGMENT a configure option [2]. I don't want to go that far; pg_config_manual.h seems like the right level of configurability to me.
Agreed. The thread referenced above never really answered why a configure time
option would be needed.
+ uint32 slru_pages_per_segment; /* size of each SLRU segment */
Should this be expanded ever so slightly? A new reader of the code might
wonder about the relationship between "pages_per" and "size".
No objections (apart from the catversion =)) from reading the patch.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2025-11-10 11:58:13 | Re: Fix a typo in the comment for gettuple_eval_partition() |
| Previous Message | Álvaro Herrera | 2025-11-10 11:30:18 | Re: Remove unused for_all_tables field from AlterPublicationStmt |