| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "Andres Freund" <andres(at)anarazel(dot)de>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Lyes Ameddah <lyes(dot)amd(at)gmail(dot)com> |
| Subject: | Re: Add SKIP LOCKED to VACUUM and ANALYZE |
| Date: | 2018-09-04 15:49:09 |
| Message-ID: | 0D38420F-7D79-4675-832E-53B9527214F4@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9/3/18, 6:20 PM, "Michael Paquier" <michael(at)paquier(dot)xyz> wrote:
> Nathan, could you rebase your patch set? From what I can see the last
> patch set applies with one conflict, and it would be nice for clarity to
> split the routines for analyze, vacuum and cluster into separate places.
> Similar to what is done with vacuum_is_relation_owner, having the same
> set of logs for vacuum and analyze may be cleaner. The set of ownership
> checks should happen after the skip lock checks to be consistent between
> the ownership checks done when building the relation list (list
> expansion for partitions and such) as well as for vacuum_rel() and
> analyze_rel().
Yes. I've started working on this again, but the new patch set is
probably still a few days out.
> With all the work which has been done already, I don't think that we are
> that far from getting something committable.
Great!
Nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2018-09-04 16:38:50 | Re: Bug fix for glibc broke freebsd build in REL_11_STABLE |
| Previous Message | Tom Lane | 2018-09-04 14:52:07 | pgsql: Clean up after TAP tests in oid2name and vacuumlo. |