| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] psql: Complete INDEX after REPACK USING |
| Date: | 2026-11-09 01:08:51 |
| Message-ID: | 0CBF9DAC-AE80-41D9-B2D2-96989F474C84@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Nov 9, 2026, at 06:23, Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com> wrote:
>
> Hi hackers,
>
> After manually typing `REPACK USING ` and pressing Tab, psql inserts
> another `USING INDEX`, producing `REPACK USING USING INDEX`. After an
> explicit table name, `REPACK tab1 USING ` offers no completion.
>
> The attached fix completes `INDEX` after `USING`, with or without an
> option list, table name, or column list.
>
> Regression tests are attached as a separate patch.
>
> I tested on master with assertions enabled. The new tests fail without
> the fix, and all psql TAP tests pass with it.
>
> I have also posted a separate fix for index completion after a
> `REPACK` column list [1]. The two fixes are independent.
>
> [1] https://www.postgresql.org/message-id/CAG7L5%2B7Xmus%2BJLa0m%3DLpw49wU%3DsecPm5dzNd2ibmfvhdSYEfqA%40mail.gmail.com
>
> Thanks,
> Sho
>
> --
> =======================================
> Sho Ito (Sean)
>
> E-mail: i(dot)sho(dot)0628(at)gmail(dot)com
> LinkedIn: https://www.linkedin.com/in/sho-ito-0628/
> GitHub: https://github.com/sean0628/
> =======================================
> <v1-0001-psql-Complete-INDEX-after-REPACK-USING.patch><v1-0001-psql-Test-completion-after-REPACK-USING.patch>
Please see my comment in the other your patch of “Fix REPACK index completion after a column list”.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Xuneng Zhou | 2026-11-09 02:39:37 | Re: BGWORKER_INTERRUPTIBLE workers are never restarted after DROP/ALTER/CREATE DATABASE |
| Previous Message | Chao Li | 2026-11-09 01:07:39 | Re: [PATCH] psql: Fix REPACK index completion after a column list |