From: | "David E(dot) Wheeler" <david(at)justatheory(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Mankirat Singh <mankiratsingh1315(at)gmail(dot)com>, pg(at)bowt(dot)ie, andrew(at)dunslane(dot)net, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats() |
Date: | 2025-10-20 21:39:10 |
Message-ID: | 0C8DBCD6-7D68-4FD6-AE66-12B03AE7671B@justatheory.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Oct 20, 2025, at 22:14, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I do take your point that being able to find things before commit
> is helpful. But I think the answer to that is to get this
> general-purpose ABI check mechanism sufficiently well product-ized
> that committers can run it locally if they choose. Ideally we'd
> have multiple BF animals running it, so there's definitely motivation
> to get it at least to the point where it doesn't require hand-feeding
> by BF owners. (If memory serves, we've had ABI breaks that affected
> only 32 bit or only 64 bit machines, and of course there's the
> possibility of ones that only manifest with particular feature
> selections. So I'm not content with just one animal running it.)
FWIW, running it on a Linux animal currently requires just a couple steps
1. Download the module:
```sh
curl -LO https://raw.githubusercontent.com/MankiratSingh1315/pg-bf-client-code/refs/heads/abi-comp-check/PGBuild/Modules/ABICompCheck.pm
mv ABICompCheck.pm build-farm-path/PGBuild/Modules/
```
2. Add it to `modules` in `build-farm.conf`, e.g.,
modules => [qw(TestUpgrade ABICompCheck)],
3. Install the abigail suite; I believe the Debian packages are `abigail-tools` and `libabigail0`
I think that’s it. I use `run_branches.pl --run-all` to test all the current maintenance branches. It does not run against master.
Best,
David
From | Date | Subject | |
---|---|---|---|
Next Message | John H | 2025-10-20 22:03:55 | Re: Making pg_rewind faster |
Previous Message | Mihail Nikalayeu | 2025-10-20 21:30:43 | Re: Fix race condition in SSI when reading PredXact->SxactGlobalXmin |