From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
---|---|
To: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Error message against unknown key in pg_service.conf is unclear |
Date: | 2025-10-16 23:00:52 |
Message-ID: | 0C613D16-6C8B-4CD4-9B47-70736489C290@gmail.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On Oct 17, 2025, at 00:27, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> wrote:
>
> On Wed, Oct 15, 2025 at 7:30 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>> The error message showed the correct line number, but “syntax error” is confusing. Shouldn’t it be something like “invalid configuration parameter: default”?
>
> I think so; see patch 0003 in [1].
>
> --Jacob
>
> [1] https://postgr.es/m/CAOYmi%2BkYKPXCfiAF3xAu%2BcHYSLYEc4OC9Wsh2nebwWboNbkpeQ%40mail.gmail.com
Cool! So, patch 0003 should more likely belong to this discussion. :)
I reviewed and tested 0003. But I failed to “git am” it, maybe need a rebase. So I manually applied the change to my local.
The change looks good to me. And the new TAP test also passed in my side. I think we can push this patch separately.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2025-10-16 23:23:48 | Re: [BUG] temporary file usage report with extended protocol and unnamed portals |
Previous Message | John H | 2025-10-16 22:55:06 | Re: Making pg_rewind faster |