Re: PATCH: Add hstore_to_json()

On Dec 16, 2009, at 2:45 PM, Robert Haas wrote:

> I like it. The regression tests you've added seem to cover a lot of
> cases that aren't really different without covering some that are
> probably worth trying, like multiple key/value pairs. Also, the
> comment in the function you've added looks like a cut-and-paste from
> somewhere else, which might not be the best way to document. With
> regard to the underlying issue, why can't we just use a StringInfo and
> forget about it?

Dunno. I just duped hstore_out(). I agree there should be more edge cases.

> Also, your indentation is not entirely consistent. If this gets
> consensus, that will have to be fixed before it can be committed, so
> it would be nice if you could do that rather than leaving it for the
> eventual committer.

The indentation is also largely copied; wouldn't pg_indent fix it?

Best,

David