| From: | "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> |
|---|---|
| To: | 'Tom Lane' <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: [bug fix??] Fishy code in tts_cirtual_copyslot() |
| Date: | 2019-09-23 23:59:07 |
| Message-ID: | 0A3221C70F24FB45833433255569204D1FD49C48@G01JPEXMBYT05 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]
> I temporarily changed the Assert to be "==" rather than "<=", and
> it still passed check-world, so evidently we are not testing any
> cases where the descriptors are of different lengths. This explains
> the lack of symptoms. It's still a bug though, so pushed.
Thank you for committing.
> > BTW, I thought that in PostgreSQL coding convention, local variables
> should be defined at the top of blocks, but this function writes "for (int
> natts;".
>
> Yeah, we've agreed to join the 21st century to the extent of allowing
> local for-loop variables.
That's good news. It'll help a bit to code comfortably.
Regards
Takayuki Tsunakawa
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2019-09-24 00:13:32 | Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index. |
| Previous Message | Michael Paquier | 2019-09-23 23:58:50 | Re: Cache lookup errors with functions manipulation object addresses |