RE: [bug fix] Cascaded standby cannot start after a clean shutdown

From: "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>
To: 'Michael Paquier' <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: RE: [bug fix] Cascaded standby cannot start after a clean shutdown
Date: 2018-03-16 06:02:25
Message-ID: 0A3221C70F24FB45833433255569204D1F903DF1@G01JPEXMBYT05
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

From: Michael Paquier [mailto:michael(at)paquier(dot)xyz]
> We use palloc_extended with MCXT_ALLOC_NO_OOM in 9.5~, and malloc() further
> down, so once you remove the FATAL error caused by a record whose length
> is higher than 1GB, you discard all the hard failures, no?

Ouch, you're right. If memory allocation fails, the startup process would emit a LOG message and continue to fetch new WAL records. Then, I'm completely happy with your patch.

I added you as the author, and marked this as ready for committer.

Regards
Takayuki Tsunakawa

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Prabhat Sahu 2018-03-16 06:05:13 segmentation fault in pg head with SQL function.
Previous Message Michael Paquier 2018-03-16 05:47:47 Re: [bug fix] Cascaded standby cannot start after a clean shutdown