Re: Potential data loss of 2PC files

From: "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>
To: 'Ashutosh Bapat' <ashutosh(dot)bapat(at)enterprisedb(dot)com>, David Steele <david(at)pgmasters(dot)net>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Potential data loss of 2PC files
Date: 2017-03-17 08:11:25
Message-ID: 0A3221C70F24FB45833433255569204D1F6B50F7@G01JPEXMBYT05
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

From: pgsql-hackers-owner(at)postgresql(dot)org
> [mailto:pgsql-hackers-owner(at)postgresql(dot)org] On Behalf Of Ashutosh Bapat
> The scope of this work has expanded, since last time I reviewed and marked
> it as RFC. Right now I am busy with partition-wise joins and do not have
> sufficient time to take a look at the expanded scope.
> However, I can come back to this after partition-wise join, but that may
> stretch to the end of the commitfest. Sorry.

I marked this as ready for committer. The code looks good, make check passed, ran read/write pgbench for some period to cause checkpoint with WAL file removal, and pg_ctl stop. The checkpoint emitted the following message, and there were no message like "could not ..." that indicates a file unlink or directory sync failure.

LOG: checkpoint complete: wrote 1835 buffers (11.2%); 0 transaction log file(s) added, 1 removed, 0 recycled; write=0.725 s, sync=0.002 s, total=0.746 s; s\
ync files=9, longest=0.002 s, average=0.000 s; distance=16381 kB, estimate=16381 kB

Regards
Takayuki Tsunakawa

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-03-17 08:15:19 Re: Speedup twophase transactions
Previous Message Nikhil Sontakke 2017-03-17 08:00:01 Re: Speedup twophase transactions