Re: PATCH: Make pg_stop_backup() archive wait optional

From: "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>
To: 'Michael Paquier' <michael(dot)paquier(at)gmail(dot)com>
Cc: David Steele <david(at)pgmasters(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>
Subject: Re: PATCH: Make pg_stop_backup() archive wait optional
Date: 2017-03-17 05:01:56
Message-ID: 0A3221C70F24FB45833433255569204D1F6B3FC5@G01JPEXMBYT05
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> From: pgsql-hackers-owner(at)postgresql(dot)org
> [mailto:pgsql-hackers-owner(at)postgresql(dot)org] On Behalf Of Michael Paquier
> On Fri, Mar 17, 2017 at 1:47 PM, Tsunakawa, Takayuki
> <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> wrote:
> > BTW, does the developer of each feature have to modify the catalog version
> in catversion.h? It's a bit annoying to see the patch application failure
> on catversion.h.
>
> Committers take care of this part.

I understood the committer modifies the catalog version based on the patch content, so the patch submitter doesn't have to modify it. I'm relieved.

> > Isn't it enough to modify the catalog version only when
> alpha/beta/RC/final versions are released?
>
> That's useful at least for developers to bump it even during a development
> cycle as you can notice with a hard failure at startup if a data folder
> you have created is compatible with the new binaries or not.

Oh, you're absolutely right.

Regards
Takayuki Tsunakawa

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-03-17 05:14:50 Re: Speedup twophase transactions
Previous Message Michael Paquier 2017-03-17 04:54:58 Re: PATCH: Make pg_stop_backup() archive wait optional