| From: | "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> |
|---|---|
| To: | 'Michael Paquier' <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | MauMau <maumau307(at)gmail(dot)com>, Breen Hagan <breen(at)rtda(dot)com>, "Heikki Linnakangas" <hlinnaka(at)iki(dot)fi>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled |
| Date: | 2016-11-08 06:31:10 |
| Message-ID: | 0A3221C70F24FB45833433255569204D1F63C8CA@G01JPEXMBYT05 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
From: Michael Paquier [mailto:michael(dot)paquier(at)gmail(dot)com]
> I just looked more deeply at your refactoring patch, and I didn't know about
> CheckTokenMembership()... The whole logic of your patch depends on it.
> That's quite a cleanup that you have here. It looks that the former
> implementation just had no knowledge of this routine or it would just have
> been used.
Yes, Microsoft recommends GetTokenMembership() because it's simpler.
> + if (IsAdministrators || IsPowerUsers)
> + return 1;
> + else
> + return 0;
> I would remove the else here.
IIRC, I sometimes saw this style of code in PostgreSQL (or in psqlODBC possibly...) I'd like to leave the style choice to the committer.
Regards
Takayuki Tsunakawa
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Steve Randall | 2016-11-09 17:43:52 | Parallel Scan Bug: invalid attnum: 0 |
| Previous Message | Michael Paquier | 2016-11-08 05:56:03 | Re: Re: BUG #13755: pgwin32_is_service not checking if SECURITY_SERVICE_SID is disabled |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2016-11-08 06:42:02 | Re: Declarative partitioning - another take |
| Previous Message | Michael Paquier | 2016-11-08 06:01:05 | Re: Incorrect overflow check condition for WAL segment size |