|From:||"Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>|
|To:||'Robert Haas' <robertmhaas(at)gmail(dot)com>|
|Subject:||Re: Supporting huge pages on Windows|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
> From: pgsql-hackers-owner(at)postgresql(dot)org
> [mailto:pgsql-hackers-owner(at)postgresql(dot)org] On Behalf Of Robert Haas
> On Sun, Sep 25, 2016 at 10:45 PM, Tsunakawa, Takayuki
> <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> wrote:
> > Credit: This patch is based on Thomas Munro's one.
> How are they different?
As Thomas mentioned, his patch (only win32_shmem.c) might not have been able to compile (though I didn't try.) And it didn't have error processing or documentation. I added error handling, documentation, comments, and a little bit of structural change. The possibly biggest change, though it's only one-liner in pg_ctl.c, is additionally required. I failed to include it in the first patch. The attached patch includes that.
|Next Message||Mark Dilger||2016-09-28 00:32:14||Re: gratuitous casting away const|
|Previous Message||Andres Freund||2016-09-28 00:16:07||Re: typedef FileName not const?|