| From: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Subject: | Re: logical replication launcher crash on buildfarm |
| Date: | 2017-04-01 00:32:41 |
| Message-ID: | 09d8ad33-4287-a09b-a77f-77f8761adb5e@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 31/03/17 15:42, Robert Haas wrote:
> On Tue, Mar 28, 2017 at 7:39 PM, Petr Jelinek
> <petr(dot)jelinek(at)2ndquadrant(dot)com> wrote:
>> Sigh, forgot git add for the docs, so one more try...
>
> + if (strncmp(worker->bgw_library_name, "postgres", 8) != 0)
> + return NULL;
>
> I think that's not right. You don't want to match postgresshdkgjsdglkjs.
>
Right, changed to BGW_MAXLEN.
> Aside from that, these look good to me.
>
Cool.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| Use-library_name-function_name-for-loading-main-entr-96-v2.patch | application/x-patch | 6.8 KB |
| Use-library_name-function_name-for-loading-main-entr-HEAD-v2.patch | application/x-patch | 14.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-04-01 00:53:04 | Re: logical replication launcher crash on buildfarm |
| Previous Message | Robert Haas | 2017-04-01 00:30:57 | Re: [sqlsmith] Failed assertion in _hash_kill_items/MarkBufferDirtyHint |