Re: Real config values for bytes needs quotes?

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Real config values for bytes needs quotes?
Date: 2023-03-02 10:54:10
Message-ID: 09c2b9cb-6f73-8e83-a84e-29a2925a9eed@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 27.02.23 09:32, Kyotaro Horiguchi wrote:
> I found it frustrating that the line "shared_buffers = 0.1GB" in
> postgresql.conf postgresql.conf was causing an error and that the
> value required (additional) surrounding single quotes. The attached
> patch makes the parser accept the use of non-quoted real values
> followed by a unit for such variables. I'm not sure if that syntax
> fully covers the input syntax of strtod, but I beieve it is suffucient
> for most use cases.

This seems sensible to fix. If you're not sure about the details, write
some test cases. :)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2023-03-02 11:05:02 Re: Refactoring SysCacheGetAttr to know when attr cannot be NULL
Previous Message Julien Rouhaud 2023-03-02 10:50:56 Re: pg_upgrade and logical replication