| From: | "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com> |
|---|---|
| To: | "Imseih (AWS), Sami" <simseih(at)amazon(dot)com>, "Schneider (AWS), Jeremy" <schnjere(at)amazon(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Query Jumbling for CALL and SET utility statements |
| Date: | 2022-09-02 09:06:50 |
| Message-ID: | 09c04aba-7f12-e524-20f7-3f92c1479fdf@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 9/1/22 5:13 PM, Imseih (AWS), Sami wrote:
>
> > Please find attached v2 as an attempt to do so.
>
> +1 to the idea.
>
Thanks for looking at it!
> I think it will be better to evaluate jstate instead of
>
> JUMBLE_UTILITY, such as:
>
> if (query->utilityStmt && !jstate)
>
> instead of
>
> if (query->utilityStmt && !JUMBLE_UTILITY(query->utilityStmt))
>
> This will allow for support of potentially other utility statements
>
> In the future without having to teach pg_stat_statements about them.
>
> If a jstate is set for the utility statements, pgss will do the right
> thing.
>
Fair point, thanks!
v3 including this change is attached.
Thanks,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services:https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-JumbleQuery-on-Call-and-Set.patch | text/plain | 15.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2022-09-02 09:19:12 | Re: plpgsql-trigger.html: Format TG_ variables as table (patch) |
| Previous Message | David Rowley | 2022-09-02 08:52:54 | Re: Add the ability to limit the amount of memory that can be allocated to backends. |