Re: document pg_settings view doesn't display custom options

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: document pg_settings view doesn't display custom options
Date: 2020-11-09 06:12:47
Message-ID: 09b4b914-7fcf-b337-b3cd-55569cf24a48@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020/11/07 0:42, Fujii Masao wrote:
>
>
> On 2020/10/31 2:06, John Naylor wrote:
>>
>>
>> On Fri, Oct 30, 2020 at 12:48 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us <mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us>> wrote:
>>
>>     John Naylor <john(dot)naylor(at)enterprisedb(dot)com <mailto:john(dot)naylor(at)enterprisedb(dot)com>> writes:
>>      > Okay, along those lines here's a patch using "this view" in a new paragraph
>>      > for simplicity.
>>
>>     Basically OK with me, but ...
>>
>>     <quibble>
>>     It seems fairly weird to use a nonspecific reference first and then a
>>     specific one.  That is, I'd expect to read "The pg_settings view ..."
>>     and then "This view ...", not the other way around.  So we could
>>     put this para second, or put it first but make this para say
>>     "The pg_settings view ..." while the existing text gets reduced to
>>     "This view ...".
>>
>>     Or just make them both say "This view ..." so we don't have to have
>>     this discussion again the next time somebody wants to add a para here.
>>     </quibble>
>>
>>
>> Okay, how's this?
>
> Looks good to me. Barring any objection, I will commit the patch.

Pushed. Thanks!

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2020-11-09 06:23:12 Re: Temporary tables versus wraparound... again
Previous Message Michael Paquier 2020-11-09 06:08:21 Re: abstract Unix-domain sockets