Re: bailing out in tap tests nearly always a bad idea

On 2/23/22 11:40, Andres Freund wrote:
> Hi,
>
> On 2022-02-23 08:43:38 -0500, Andrew Dunstan wrote:
>> On 2/22/22 15:54, Andres Freund wrote:
>>> On 2022-02-22 15:10:30 -0500, Andrew Dunstan wrote:
>>>> I'll be surprised if we can't come up with something cleaner than that.
>>> Suggestions?
>>
>> If we just have the sig handler actions as:
>>
>>     diag("died: $_[0]");
>>     done_testing();   
>>
>> we get:
>>
>>     ok 1 - foo
>>     # died: blorb at tst/tst.pl line 5.
>>     1..1
>>     # Looks like your test exited with 25 just after 1.
>>
>>
>> Would that work?
> Well, the if condition I had is needed, afaics. Otherwise we break eval() and
> / or risk crashing on syntax errors. If you're just talking about diag() vs
> ok(0, ...), I'm good with that.

Yes, sorry, I meant this should be the contents of the condition block.
I agree completely that it's necessary.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com