| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Alexander Kuzmenkov <a(dot)kuzmenkov(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Avoid extra Sort nodes between WindowAggs when sorting can be reused |
| Date: | 2018-09-12 20:32:59 |
| Message-ID: | 09AAAA20-F9AB-4F15-98A8-04B146BED6FE@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 12 Sep 2018, at 22:15, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> wrote:
> WindowClauseSortNode - I don't like this name, because it's not actually
> a Node of any kind. How about WindowSortData?
That’s a good point. I probably would’ve named it WindowClauseSortData since
it acts on WindowClauses, but that might just be overly verbose.
> Any comments? (no need to post further patches unless there's some major
> change needed)
I have no objections to the comments made in this review, only the above
nitpick.
Thanks for picking this up!
cheers ./daniel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-09-12 20:53:46 | Re: Code of Conduct plan |
| Previous Message | Andrew Gierth | 2018-09-12 20:15:02 | Re: Avoid extra Sort nodes between WindowAggs when sorting can be reused |