> v3 looks good to me.
Cool!
> One thing I put under 0002 last time is really about 0001. With
> ST_COMPARE_RUNTIME_POINTER and a pointer element type, the typedef
> gives const Item ** but the sort passes Item **, so clang does not like it.
>
>
> Writing ST_ELEMENT_TYPE const * in the typedef fixes it.
I see. But seems like nothing in our code base triggers that. I leave it
to John to make the call if we want to fix that or leave as is for now.
--
David Geier