Re: [PATCH] Introduce array_shuffle() and array_sample()

From: Martin Kalcher <martin(dot)kalcher(at)aboutsource(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Introduce array_shuffle() and array_sample()
Date: 2022-07-19 11:15:42
Message-ID: 091a9f69-1e5d-6558-41a7-2607a5fc9ff7@aboutsource.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Am 18.07.22 um 23:48 schrieb Martin Kalcher:
>
> If we go with (1) array_shuffle() and array_sample() should shuffle each
> element individually and always return a one-dimensional array.
>
>   select array_shuffle('{{1,2},{3,4},{5,6}}');
>   -----------
>    {1,4,3,5,6,2}
>
>   select array_sample('{{1,2},{3,4},{5,6}}', 3);
>   ----------
>    {1,4,3}
>
> If we go with (2) both functions should only operate on the first
> dimension and shuffle whole subarrays and keep the dimensions intact.
>
>   select array_shuffle('{{1,2},{3,4},{5,6}}');
>   ---------------------
>    {{3,4},{1,2},{5,6}}
>
>   select array_sample('{{1,2},{3,4},{5,6}}', 2);
>   ---------------
>    {{3,4},{1,2}}
>

Having thought about it, i would go with (2). It gives the user the
ability to decide wether or not array-of-arrays behavior is desired. If
he wants the behavior of (1) he can flatten the array before applying
array_shuffle(). Unfortunately there is no array_flatten() function (at
the moment) and the user would have to work around it with unnest() and
array_agg().

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Meera Nair 2022-07-19 11:33:44 RE: pg_dump is filling C: drive up to 100 percent
Previous Message Achilleas Mantzios 2022-07-19 10:38:33 pgsql 10.19 : "ERROR: cannot convert infinity to numeric" except there is no infinity

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Verite 2022-07-19 11:16:21 Re: BUG #17434: CREATE/DROP DATABASE can be executed in the same transaction with other commands
Previous Message Japin Li 2022-07-19 10:41:13 Re: Memory leak fix in psql