[PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message.

From: Gilles Darold <gilles(at)darold(dot)net>
To: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message.
Date: 2019-11-01 16:29:23
Message-ID: 08600ed3-3084-be70-65ba-279ab19618a5@darold.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

As per the following code, t1 is a remote table through postgres_fdw:

test=# BEGIN;
BEGIN
test=# SELECT * FROM t1;
...

test=# PREPARE TRANSACTION 'gxid1';
ERROR:  cannot prepare a transaction that modified remote tables

I have attached a patch to the documentation that adds remote tables to
the list of objects where any operation prevent using a prepared
transaction, currently it is just notified "operations involving
temporary tables or the session's temporary namespace".

The second patch modify the message returned by postgres_fdw as per the
SELECT statement above the message should be more comprehensible with:

    ERROR:  cannot PREPARE a transaction that has operated on remote tables

like for temporary objects:

    ERROR:  cannot PREPARE a transaction that has operated on temporary
objects

Best regards,

--

Gilles

--
Gilles Darold
http://www.darold.net/

Attachment Content-Type Size
fix_prepare_transaction_doc-v1.diff text/x-patch 957 bytes
fix_message_pg_fdw_v1.diff text/x-patch 592 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2019-11-01 16:30:49 Re: [PATCH] Implement INSERT SET syntax
Previous Message Robert Haas 2019-11-01 16:22:06 Re: On disable_cost