| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: logical replication and PANIC during shutdown checkpoint in publisher |
| Date: | 2017-05-01 22:07:51 |
| Message-ID: | 069d14b6-eb3d-978f-7bc2-c80fda78d5ee@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 4/25/17 21:47, Michael Paquier wrote:
> Attached is an updated patch to reflect that.
I edited this a bit, here is a new version.
A variant approach would be to prohibit *all* new commands after
entering the "stopping" state, just let running commands run. That way
we don't have to pick which individual commands are at risk. I'm not
sure that we have covered everything here.
More reviews please. Also, this is a possible backpatching candidate.
Also, if someone has a test script for reproducing the original issue,
please share it, or run it against this patch.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Prevent-panic-during-shutdown-checkpoint.patch | invalid/octet-stream | 14.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-05-01 22:10:04 | Re: snapbuild woes |
| Previous Message | Greg Stark | 2017-05-01 21:40:05 | Re: A design for amcheck heapam verification |