Re: [PATCH] Negative Transition Aggregate Functions (WIP)

From: Florian Pflug <fgp(at)phlo(dot)org>
To: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kevin Grittner <kgrittn(at)ymail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, Greg Stark <stark(at)mit(dot)edu>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Negative Transition Aggregate Functions (WIP)
Date: 2014-04-07 13:09:42
Message-ID: 066409B3-B2FA-4E70-BD51-6CA0A1C970B8@phlo.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Apr5, 2014, at 09:55 , Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
> On 5 April 2014 08:38, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
>> [snip] releasing it in this state feels a little half-baked
>> to me.
>>
>
> I regret writing that almost as soon as I sent it. The last of those
> queries is now over 10 times faster than HEAD, which is certainly
> worthwhile. What bugs me is that there is so much more potential in
> this patch.

Well, the perfect is the enemy of the good as they say. By all means,
let's get rid of the O(n^2) behaviour in 9.5, but let's get a basic
version into 9.4.

> I think it's pretty close to being committable, but I fear that time
> is running out for 9.4.

I'm not aware of any open issues in the basic patch, other then
scaling the reported calling statistics by nloops, which should be
trivial. I'll post an updated patch later today.

I don't really expect all the add-on patches to make it into 9.4 -
they don't seem to have gotten much attention yet - but at least
the inverse transition functions for the basic arithmetic aggregates
should be doable I hope.

best regards,
Florian Pflug

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Rajeev rastogi 2014-04-07 13:10:37 Re: Proposal: COUNT(*) (and related) speedup
Previous Message Stephen Frost 2014-04-07 12:42:24 Re: automatically updating security barrier views