Re: tab_complete for copy(merge

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: jian he <jian(dot)universality(at)gmail(dot)com>, Kirill Reshke <reshkekirill(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: tab_complete for copy(merge
Date: 2024-11-28 11:11:05
Message-ID: 064da763-c86f-4c3e-b02e-7afd589b0698@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 19.11.24 14:23, jian he wrote:
> On Tue, Nov 19, 2024 at 5:20 PM Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
>> On Tue, 19 Nov 2024, 14:08 jian he, <jian(dot)universality(at)gmail(dot)com> wrote:
>>> in v17, we support COPY(MERGE RETURNING)
>>> we can add tab_complete for it.
>>
>>
>> Sounds sane
>>>
>>> /* Complete COPY ( with legal query commands */
>>> else if (Matches("COPY|\\copy", "("))
>>> - COMPLETE_WITH("SELECT", "TABLE", "VALUES", "INSERT
>>> INTO", "UPDATE", "DELETE FROM", "WITH");
>>> + COMPLETE_WITH("SELECT", "TABLE", "VALUES", "INSERT
>>> INTO", "UPDATE", "DELETE FROM", "WITH", "MERGE INTO");
>>
>> MERGE INTO?
>>
>
> per Synopsis
> https://www.postgresql.org/docs/current/sql-merge.html
> it should be "MERGE INTO".

Yes, we also complete "MERGE INTO" in other contexts.

Committed like that.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2024-11-28 11:14:30 Re: Difference in dump from original and restored database due to NOT NULL constraints on children
Previous Message Ashutosh Bapat 2024-11-28 11:10:08 Re: [Feature Request] Schema Aliases and Versioned Schemas