| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Alexander Lakhin <exclusion(at)gmail(dot)com>, Michael Zhilin <m(dot)zhilin(at)postgrespro(dot)ru>, pgsql-bugs(at)postgresql(dot)org, Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru> |
| Subject: | Re: [BUG] false positive in bt_index_check in case of short 4B varlena datum |
| Date: | 2026-05-12 09:17:27 |
| Message-ID: | 06434787-C6A1-4551-A2C3-F86DC892601B@yandex-team.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
> On 9 May 2026, at 04:07, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Mon, May 04, 2026 at 10:20:04AM +0500, Andrey Borodin wrote:
>> However, I'd like to note that (VARSIZE_1B() < TOAST_INDEX_TARGET) is
>> constantly true for 8Kb+ pages.
>
> How much slower? I cannot imagine that it matters much in this code
> path, but you are getting me worried.
I think there will be no performance difference.
Change proposed by Alexander only prevents use of VARSIZE() against datum
that is VARSIZE_1B. AFAICS no actual behavior would change.
On some occasions we would have to normilize less tuples.
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2026-05-12 10:22:59 | Re: [BUG] false positive in bt_index_check in case of short 4B varlena datum |
| Previous Message | Nathan Bossart | 2026-05-11 14:24:02 | Re: BUG #19475: VACUUM on a partition still warns after MAINTAIN is granted on the partitioned parent |