| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Update Windows CI Task Names: Server 2022 + VS 2022 Upgrade |
| Date: | 2025-09-11 14:18:29 |
| Message-ID: | 06373a65-450a-40f3-b1ce-5d0373f60e8c@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 08.09.25 10:25, Nazir Bilal Yavuz wrote:
> Tasks have short names to select them and the 'Windows VS 2019' task's
> name was 'windows' (i.e: ci-os-only: windows) but since we have two
> Windows tasks now; we need to have different names for VS 2019 and VS
> 2022 tasks. To preserve the same behavior, VS 2022 task uses 'windows'
> but VS 2019 is renamed to 'vs2019' (i.e: ci-os-only: vs2019). I am not
> completely convinced about this naming, I am open to suggestions.
I don't think we need this level of complication. We already have the
situation that for example "linux" covers several tasks, and "windows"
also covers several tasks, one of which is manually triggered. The
"ci-os-only: vs2019" is not very useful anyway, since it's manually
triggered. So just applying "windows" to both of them seems ok to me.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2025-09-11 14:27:36 | Re: ALTER DATABASE RESET with unexistent guc doesn't report an error |
| Previous Message | Peter Eisentraut | 2025-09-11 14:11:43 | Re: Only one version can be installed when using extension_control_path |