| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, Maksim Milyutin <m(dot)milyutin(at)postgrespro(dot)ru>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Partitioned tables and relfilenode |
| Date: | 2017-04-11 09:16:51 |
| Message-ID: | 062ab583-767d-9d08-5c7c-16b674a4c279@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017/04/03 11:39, Amit Langote wrote:
> On 2017/04/01 5:29, Robert Haas wrote:
>> Thanks for reviewing, and thanks to Maksim as well, and thanks to Amit
>> for writing the patch.
>
> Thanks for committing. :)
I noticed that I had missed a couple of places that would try to scan
partitioned tables, resulting in file access.
1. In validateCheckConstraint(), along with foreign tables, must ignore
partitioned tables.
2. DefineQueryRewrite() may try to scan a partitioned table in the case of
converting a table to view, where we must make sure that the table being
converted is empty. It's checked by scanning the heap, which we should
not do for a partitioned table. Nor should we try to drop the storage
once ready to make the table into a REKIND_VIEW relation (because all
other checks passed okaying the conversion).
Tests are added for both the cases.
Thanks,
Amit
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-few-places-still-scanning-partitioned-tables.patch | text/x-diff | 7.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2017-04-11 09:17:22 | Re: Merge join for GiST |
| Previous Message | Magnus Hagander | 2017-04-11 09:15:18 | Function to control physical replication slot |