Re: Allow to_date() and to_timestamp() to accept localized names

From: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Arthur Zakirov <zaartur(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Allow to_date() and to_timestamp() to accept localized names
Date: 2020-01-28 19:05:09
Message-ID: 06220D86-5D3B-4EAA-860D-4328F926010F@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Jan 28, 2020, at 9:30 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> A brute-force answer, if there are few enough cases, is to recognize
> them regardless of the specific value of LC_TIME. Do we think
> anybody would notice or care if to_date('Sonnabend', 'TMDay') works
> even when in a non-German locale?

I think this only becomes a problem if there are weekday or month name collisions between languages where they have different meanings. As an absurd hypothetical, if “Sunday” in Tagalog means what “Tuesday” means in English, then you’ve got a problem.

This does happen for month abbreviations. “Mar” is short for “March” and variations in a number of languages, but short for “November” in Finnish.

For day abbreviations, “Su” collides between fi_FI and hr_HR, and “tor” collides between sl_SL and no_NO.

I don’t see any collisions with full month or full weekday names, but I’m also only looking at the 53 locales installed in /usr/share/locale/.*/LC_TIME on my mac.


Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2020-01-28 19:27:06 Re: Is custom MemoryContext prohibited?
Previous Message Robert Haas 2020-01-28 19:03:10 Re: making the backend's json parser work in frontend code