Re: CI: Add task that runs pgindent

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Jelte Fennema-Nio <me(at)jeltef(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Subject: Re: CI: Add task that runs pgindent
Date: 2025-10-21 17:39:39
Message-ID: 05e7413c-9201-4461-af89-f945239d6fe5@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 21.10.25 14:19, Jelte Fennema-Nio wrote:
> At PGConf.dev 2025 one thing that came up in the "Scaling PostgreSQL
> Development" unconference session is that new hackers don't know all the
> details of our development flow by heart yet. Of course it's documented
> on the wiki, but even if they find the relevant wiki pages they often
> still miss/forget things. One of the things they often forget is
> formatting their code. The consensus at that session was that it was
> probably worth adding a CI task for this to nudge newcomers to indent
> their code.

Good idea.

Additional suggestions:

Maybe there is a way to cache the pg_bsd_indent build. In my testing,
the configure and build steps each take 1/3 of the build time. Could be
worth it.

Also run the git whitespace check:

git diff-tree --check `git hash-object -t tree /dev/null` HEAD

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Philip Alger 2025-10-21 17:53:34 Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement
Previous Message Tom Lane 2025-10-21 17:36:53 Re: [PATCH v4] parallel pg_restore: avoid disk seeks when jumping short distance forward