Re: Avoid unused value (src/fe_utils/print.c)

From: Alexander Lakhin <exclusion(at)gmail(dot)com>
To: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Avoid unused value (src/fe_utils/print.c)
Date: 2023-06-03 12:00:01
Message-ID: 05a99ba8-81d5-de15-5f15-0d13045f5877@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello Ranier,

03.06.2023 13:14, Ranier Vilela wrote:
> Hi,
>
> This is for Postgres 17 (head).
>
> Per Coverity.
> At function print_unaligned_text, variable "need_recordsep", is
> unnecessarily set to true and false.

Clang' scan-build detects 58 errors "Dead assignment", including that one.
Maybe it would be more sensible to eliminate all errors of this class?

Best regards,
Alexander

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-06-03 12:27:29 Re: PostgreSQL 16 Beta 1 Released!
Previous Message Aleksander Alekseev 2023-06-03 11:56:27 Should "REGRESS_OPTS = --temp-config" be working for 3rd party extensions?