Re: Avoid use deprecated Windows Memory API

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Subject: Re: Avoid use deprecated Windows Memory API
Date: 2023-03-22 10:01:39
Message-ID: 05D22864-7030-4B26-8AB2-AC694950DF0B@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 19 Mar 2023, at 23:41, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Mar 17, 2023 at 12:19:56PM -0300, Ranier Vilela wrote:
>> Rebased to latest Head.
>
> I was looking at this thread, and echoing Daniel's and Alvaro's
> arguments, I don't quite see why this patch is something we need. I
> would recommend to mark it as rejected and move on.

Unless the claimed performance improvement is measured and provides a speedup,
and the loss of zeroing memory is guaranteed safe, there doesn't seem to be
much value provided.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message wangw.fnst@fujitsu.com 2023-03-22 10:07:49 RE: Data is copied twice when specifying both child and parent table in publication
Previous Message Amit Kapila 2023-03-22 09:50:37 Re: Allow logical replication to copy tables in binary format