| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Rahila Syed <rahilasyed90(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Maksim(dot)Melnikov" <m(dot)melnikov(at)postgrespro(dot)ru> |
| Subject: | Re: Persist injection points across server restarts |
| Date: | 2025-05-30 12:55:44 |
| Message-ID: | 05D13ED2-D6D1-463D-98BC-A4F43B83753A@yandex-team.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 27 May 2025, at 05:51, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> <v3-0001-Add-InjectionPointList-to-retrieve-list-of-inject.patch>
> <v3-0002-injection_points-Add-function-to-flush-injection-.patch>
> <v3-0003-Add-regression-test-for-2PC-visibility-check-on-s.patch>
I've made another round of looking into these patches.
I think it's fine that private data is not included. But the feature looks orthogonal, and I do not see specific reasons why it should be omitted when IPs are persisted.
Another idea of improvement is using distinguishable errors in injection_shmem_startup(). Like differentiating between read error and wrong magic number.
But there's no big value in these improvements, so the patch is fine as is too.
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabrízio de Royes Mello | 2025-05-30 13:32:18 | Re: Reduce DEBUG level of catcache refreshing messages |
| Previous Message | Jelte Fennema-Nio | 2025-05-30 12:43:14 | Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE |