| From: | "pgAdmin Trac" <trac(at)code(dot)pgadmin(dot)org> |
|---|---|
| To: | |
| Cc: | pgadmin-hackers(at)postgresql(dot)org |
| Subject: | Re: [pgAdmin III] #332: SQL for TRIGGER with WHEN clause broken |
| Date: | 2011-08-12 18:23:37 |
| Message-ID: | 054.4c4b6336a51483e162bd6f93be883ad1@code.pgadmin.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
#332: SQL for TRIGGER with WHEN clause broken
----------------------+-----------------------------------------------------
Reporter: brsa | Owner: dpage
Type: patch | Status: new
Priority: minor | Milestone:
Component: pgadmin | Version: trunk
Keywords: SQL pane | Platform: all
----------------------+-----------------------------------------------------
Changes (by brsa):
* type: bug => patch
Comment:
The fix is pretty obvious in this case. The code mistakenly trims all
outer enclosing brackets, which leads to unmatched brackets in test 2.) -
both left brackets were removed.
pgTrigger.cpp, line 393:
- wxT(" trim(substring(pg_get_triggerdef(t.oid), 'WHEN (.*) EXECUTE
PROCEDURE'), '()') AS whenclause\n")
+ wxT(" substring(pg_get_triggerdef(t.oid), 'WHEN (.*) EXECUTE
PROCEDURE') AS whenclause\n")
--
Ticket URL: <http://code.pgadmin.org/trac/ticket/332#comment:1>
pgAdmin III <http://code.pgadmin.org/trac/>
pgAdmin III
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Guillaume Lelarge | 2011-08-12 20:53:08 | Re: Weird git messages |
| Previous Message | pgAdmin Trac | 2011-08-12 18:06:13 | [pgAdmin III] #332: SQL for TRIGGER with WHEN clause broken |